HDDS-3062. Fix TestOzoneRpcClientAbstract.testListVolume. #1194
Conversation
|
Ran the test 20 times locally. There were no failures. |
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @lokeshj1703 for working on this. The change itself looks good. However, I think we have some flakiness due to environmental or Ratis issues, which happens both in integration and acceptance tests (see my comment in HDDS-3907 about the latter). I think enabling further integration tests without addressing the root cause will trigger more frequent intermittent failures. We have observed this with other recently enabled integration tests (TestWatchForCommit, etc.), which were relatively stable in test runs (20x passed) but still fail intermittently in CI.
|
@adoroszlai Thanks for reviewing the PR! I agree. The appendEntries timeout issue will affect all the ratis client related tests that is why we see failures in TestWatchForCommit, TestBlockDeletion etc. But I think we can still enable tests which do not use ratis client or the tests not involved in write path. The test enabled in the PR creates a bunch of volumes and then checks if listVolumes works well. What do you think? |
There was a problem hiding this comment.
But I think we can still enable tests which do not use ratis client or the tests not involved in write path. The test enabled in the PR creates a bunch of volumes and then checks if listVolumes works well. What do you think?
Good point. This one seems safe to merge after a green run, since only one mini cluster is started per class.
|
Thanks @lokeshj1703 for the fix. |
3 participants
What changes were proposed in this pull request?
TestOzoneRpcClientAbstract.testListVolume is disabled due to intermittent issues.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3062
How was this patch tested?
Fixes UT